-
Notifications
You must be signed in to change notification settings - Fork 160
Main upgrades in preparation for contract PRs #1184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
Main upgrades in preparation for contract PRs
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR consolidates tooling and configuration upgrades to prepare for upcoming contract PRs by transitioning from Yarn to pnpm, restructuring packages to eliminate dependency cycles, and streamlining workflows and lint configurations.
- Upgrade from Yarn to pnpm across build, publish, and dependency installation tooling
- Removal of now-obsolete workflows and adjustments to configuration files for improved consistency
- Restructuring package relationships to remove dependency cycles
Reviewed Changes
Copilot reviewed 385 out of 385 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
natspec-smells.config.js | Added configuration for natspec documentation linting |
eslint.config.mjs | Updated ESLint configuration to switch from Yarn/TS plugin to pnpm-based rules |
count-patterns.txt | Added pattern file for counting Solidity contracts documentation changes |
README.md | Updated instructions and package table for pnpm and package restructuring |
.solhint.json | Removed Prettier plugin from Solhint configuration |
.prettierignore | Updated ignore file with pnpm and additional cache/build directories |
.github/workflows/* | Updated various workflows including build, publish, lint, and verify steps to use pnpm and new paths |
.github/actions/setup/action.yml | Revised setup script to use pnpm along with Foundry setup and Node.js configuration |
.devcontainer/* | Updated devcontainer scripts and configurations to support pnpm |
.changeset/smooth-balloons-stare.md | Removed a changeset file, consolidating the changeset configuration |
Comments suppressed due to low confidence (2)
.github/workflows/publish.yml:36
- Please verify that the '--no-git-checks' flag is supported by the current version of pnpm and that skipping git checks will not bypass any important validations during the publish process.
pnpm publish --tag ${{ inputs.tag }} --access public --no-git-checks
.changeset/smooth-balloons-stare.md:1
- The removal of this changeset file may affect the release process; please document the rationale for its removal to ensure clarity on how version bumps and changelog management will be handled going forward.
----
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1184 +/- ##
==========================================
- Coverage 86.06% 83.12% -2.95%
==========================================
Files 47 47
Lines 2074 2074
Branches 613 613
==========================================
- Hits 1785 1724 -61
- Misses 289 350 +61
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Large number of changes consolidating tooling, configuration, package structure, and linting. Attempts to consolidate and merge several aspects from Horizon and other WIP to both create a cleaner baseline for contract code PRs and converge upgrades across branches. A PR will also be created to merge this upgrade into
horizon
, creating a cleaner more consistent baseline.Key features:
sdk
depending oncontracts
and contracts onsdk
,contracts
has child packagescontracts-test
andcontracts-task
that depend onsdk
but thatsdk
does not depend on. These child packages depend onsdk
, whilecontracts
does not. Acommon
package has also been created for shared dependencies of contract packages. There are now no dependency cycles, noSKIP_LOAD
compiles, and dynamic loading has been converted to static imports.