[audit-09] fix: [TRST-L-6] Proper agreement version check #1206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
matiasedgeandnode
commented
Jul 24, 2025
matiasedgeandnode
commented
[audit-09] fix: [TRST-L-6] Proper agreement version check
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
matiasedgeandnode
force-pushed
the
ma/indexing-payments-audit-fixes-09-L-6
branch
from
fb374ff to
e071a73
Compare
pcarranzav
approved these changes
Jul 31, 2025
| @@ -226,7 +226,38 @@ contract SubgraphServiceIndexingAgreementAcceptTest is SubgraphServiceIndexingAg | |||
| subgraphService.acceptIndexingAgreement(ctx.indexers[0].allocationId, accepted); | |||
| } | |||
|
|
|||
| function test_SubgraphService_AcceptIndexingAgreement_Revert_WhenAgreementAlreadyAllocated() public {} | |||
| function test_SubgraphService_AcceptIndexingAgreement_Revert_WhenAgreementAlreadyAllocated( | |||
There was a problem hiding this comment.
This test seems unrelated to the fix, right? In which case it would be good to include a test for when an invalid version is supplied
There was a problem hiding this comment.
The way the code is structured, I don't think we can test for that right now. i.e. only V1 is declared in the enum.
matiasedgeandnode
force-pushed
the
ma/indexing-payments-audit-fixes-08-L-5
branch
from
54747b8 to
cd51aba
Compare
matiasedgeandnode
force-pushed
the
ma/indexing-payments-audit-fixes-09-L-6
branch
from
e071a73 to
1541b21
Compare
matiasedgeandnode
force-pushed
the
ma/indexing-payments-audit-fixes-08-L-5
branch
from
cd51aba to
836c0c2
Compare
matiasedgeandnode
force-pushed
the
ma/indexing-payments-audit-fixes-09-L-6
branch
from
1541b21 to
e3d2787
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.