Upgrade pnpm to v10, and dev container updates #1228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove hardhat-dependency-compiler plugin as it's no longer needed. The hardhat-dependency-compiler plugin was a historical workaround that is no longer necessary for the current codebase structure. Changes: - Remove hardhat-dependency-compiler import and configuration from packages/contracts/test/hardhat.config.ts - Remove getContractPaths() and findSolidityFiles() helper functions - Remove hardhat-dependency-compiler dependency from packages/contracts/test/package.json - Clean up hardhat-dependency-compiler directory reference from packages/contracts/package.json clean script - Clean up unused imports (fs)
Add core and core.* patterns to .gitignore to prevent core dump files from being accidentally committed to version control.
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades pnpm from version 9 to version 10.17.0 and modernizes the development container configuration for better maintainability and performance.
- Upgraded pnpm package manager from 9.0.6 to 10.17.0 across all configuration files
- Removed hardhat-dependency-compiler dependency and its associated configuration
- Simplified and modernized development container setup with better Python and tool integration
Reviewed Changes
Copilot reviewed 10 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updated packageManager field to [email protected] |
| .github/actions/setup/action.yml | Updated CI setup to use [email protected] |
| packages/contracts/test/package.json | Removed hardhat-dependency-compiler dependency |
| packages/contracts/test/hardhat.config.ts | Removed hardhat-dependency-compiler import and configuration |
| packages/contracts/package.json | Updated clean script to remove hardhat-dependency-compiler references |
| .devcontainer/* | Simplified dev container configuration with updated Python integration and mount points |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Upgrade pnpm to v10, and dev container updates
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1228 +/- ##
=======================================
Coverage 82.84% 82.84%
=======================================
Files 47 47
Lines 2093 2093
Branches 620 620
=======================================
Hits 1734 1734
Misses 359 359
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pnpm
Dev Container
Cleanup & Maintenance