Upgrade build and lint processing, and clear all lint issues #1233
+9,757
−5,799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
• Standardize linting configs across all packages (.solhint.json, .markdownlint.json) • Remove deprecated natspec-smells and storage verification scripts • Add new utility scripts (check-todos.sh, lint-staged-run.sh, verify-solhint-disables.js) • Update CI workflows and pnpm workspace configuration
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades build and lint processing across all packages, standardizing linting configurations and clearing lint issues. The changes include standardizing linting configs, removing deprecated tools, adding new utility scripts, updating CI workflows, and fixing comprehensive lint issues across Solidity files with NatSpec documentation improvements and lint suppressions.
Reviewed Changes
Copilot reviewed 298 out of 324 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Multiple packages | Standardized .solhint.json configurations and updated package.json scripts |
| Multiple Solidity files | Added comprehensive NatSpec documentation and lint suppressions |
| Build scripts | Updated build commands to use dependency-aware builds |
| Contract interfaces | Enhanced documentation with @author and improved @notice tags |
Comments suppressed due to low confidence (1)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
- Replace deprecated GlobSync class with globSync function - Update import to use named import from glob package - Fixes TypeScript compilation errors in CI build
RembrandtK
force-pushed
the
build-lint-upgrade
branch
from
fd63123 to
10db8fc
Compare
Upgrade build and lint processing, and clear all lint issues
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1233 +/- ##
==========================================
+ Coverage 82.84% 83.15% +0.31%
==========================================
Files 47 48 +1
Lines 2093 2096 +3
Branches 620 620
==========================================
+ Hits 1734 1743 +9
+ Misses 359 353 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The second commit message got overriden somehow to describe a minor subsequent tweak rather than the main point, the lint fixes. |
This was referenced Oct 6, 2025
…mplementation - Replace missing @graphql-mesh/utils dependency with simple local gql function - Update extraction script to generate self-contained artifacts - Fixes Hardhat initialization error: 'Cannot find module @graphql-mesh/utils' - Maintains functionality while avoiding unnecessary dependency
- Update ethereumjs-util from 7.1.3 to 7.1.5 - Ensures consistent dependency versions across environments
- Update @openzeppelin/contracts from 3.4.1 to 3.4.2 in all packages - Verified 98 contracts across 4 packages show no functional differences - Only metadata hashes changed as expected Package updates: - packages/contracts/package.json - packages/interfaces/package.json - packages/token-distribution/package.json - packages/contracts/task/package.json - packages/contracts/test/package.json Script improvements: - Add compare-repo-contract-bytecode-excluding-metadata.py for reliable repo comparisons - Remove obsolete bytecode-diff-no-metadata.sh script Verification completed: - contracts: 55 contracts ✅ functionally identical - token-distribution: 20 contracts ✅ functionally identical - horizon: 33 contracts ✅ functionally identical - subgraph-service: 12 contracts ✅ functionally identical
…uilding - Add timestamp-based checks for WAGMI, ethers-v5, and TypeScript compilation - Skip type generation when output files are newer than source files - Improve file-by-file comparison for dist directory organization - Reduce build time from 5+ seconds to ~600ms when no changes needed - Maintain build correctness while improving developer experience
The testSlash_RoundDown_TokensThawing_Delegation test was failing because it could generate scenarios where undelegating would leave less than the minimum delegation amount (1 ether) in the pool, which violates the protocol's minimum delegation constraint. Added assumption to ensure undelegation either removes all tokens or leaves at least MIN_DELEGATION in the pool, making the test compliant with the protocol's validation rules introduced in commit 91cda56.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has two main commits that can be split into separate PRs if required. (A a few trailing ones to address issues discovered.) The second is quite large and involves changing natspec for many Solidity files, while the first is smaller concentrating on build and lint processing.
feat: upgrade build processing and linting
• Standardize linting configs across all packages (.solhint.json, .markdownlint.json)
• Remove deprecated natspec-smells and storage verification scripts
• Add new utility scripts (check-todos.sh, lint-staged-run.sh, verify-solhint-disables.js)
• Update CI workflows and pnpm workspace configuration
fix(lint): resolving or suppressing all Solhint lint issues
• Add comprehensive NatSpec documentation to all contract interfaces and functions
• Suppress unavoidable lint warnings with inline comments where appropriate
• Fix visibility and naming convention issues across all contract files
• Add missing SPDX license identifiers and pragma statements
• Resolve import ordering and unused variable warnings
• Update function parameter and return value documentation
• Fix modifier and event documentation formatting