-
Notifications
You must be signed in to change notification settings - Fork 155
Killing cookbook #890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Killing cookbook #890
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably add a redirect to /subgraphs/developing/creating/install-the-cli/#safe-subgraph-code-generator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes! @benface Did we add an explanation of redirects in the contribution notes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a mention of it here, but I don't know if I would call it an "explanation" haha. I didn't want to go too much in the technical weeds in the CONTRIBUTING guide since writing Nginx rewrite rules is a whole topic, but maybe we could link to these docs? It's also very much possible to create a redirect without understanding any of it by just copying & pasting another one and modifying it slightly, potentially with the help of AI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments, but also, we should add redirects for all the pages under /subgraphs/cookbook
that got moved to /subgraphs/guides
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- After you address @benface's comments merge this baby! I'm so excited to have this change 👏
No description provided.