Skip to content

Conversation

MichaelMacaulay
Copy link
Contributor

No description provided.

@MichaelMacaulay MichaelMacaulay requested a review from a team as a code owner February 27, 2025 20:19
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably add a redirect to /subgraphs/developing/creating/install-the-cli/#safe-subgraph-code-generator

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes! @benface Did we add an explanation of redirects in the contribution notes?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a mention of it here, but I don't know if I would call it an "explanation" haha. I didn't want to go too much in the technical weeds in the CONTRIBUTING guide since writing Nginx rewrite rules is a whole topic, but maybe we could link to these docs? It's also very much possible to create a redirect without understanding any of it by just copying & pasting another one and modifying it slightly, potentially with the help of AI.

Copy link
Contributor

@benface benface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, but also, we should add redirects for all the pages under /subgraphs/cookbook that got moved to /subgraphs/guides.

Copy link
Contributor

@idalithb idalithb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • After you address @benface's comments merge this baby! I'm so excited to have this change 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants