reading time & last updated indicator designs #891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
0xa3k5
commented
Feb 28, 2025
0xa3k5
commented
- add Hourglass icon for reading time
- add Calendar icon for last updated
- make "edit this page" always on the bottom of the page (remove it from the TOC)
benface
reviewed
Mar 2, 2025
benface
reviewed
Mar 2, 2025
benface
reviewed
Mar 2, 2025
benface
reviewed
Mar 2, 2025
benface
reviewed
Mar 2, 2025
benface
reviewed
Mar 2, 2025
benface
reviewed
Mar 2, 2025
benface
reviewed
Mar 2, 2025
| </mask> | ||
|
|
||
| <g mask="url(#hourglass-mask)"> | ||
| <rect x="3.5" y={15 - value} width="9" height={value} fill="currentColor" /> |
There was a problem hiding this comment.
What happens if value is a ridiculously huge number? :P
There was a problem hiding this comment.
it works till this number, after that it just doesnt render the mask, i think this edge case is negligible wdyt?
benface
reviewed
Mar 2, 2025
…arIcon today's date
benface
reviewed
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.