Skip to content

Add resources for chain-specific landing pages #923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 9, 2025
Merged

Add resources for chain-specific landing pages #923

merged 3 commits into from
Apr 9, 2025

Conversation

hayderkg
Copy link
Contributor

@hayderkg hayderkg commented Apr 8, 2025

  • Extract feature detection into getNetworkFeatures
  • Created a getResourceCardsConfig function to handle resource card selection
  • Simplified main component
  • Created ResourceCards.tsx to extract the renderig logic into CardSection and remove code duplication in the cards layouts

@hayderkg hayderkg requested a review from a team as a code owner April 8, 2025 08:38
hayderkg and others added 2 commits April 8, 2025 10:42
@hayderkg
NetworkDetailsPage - fix lint
b67a5da
@0xa3k5
use css for layout controls (#924)
109b4bd 
* leverage css to control layout

* replace use of as any

* lint
hayderkg
hayderkg commented Apr 8, 2025
View reviewed changes
Copy link
Contributor Author

@hayderkg hayderkg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but it's a bit verbose to repeat it in each case. Maybe we should keep a closer eye on it later.

@hayderkg hayderkg merged commit 481de29 into main Apr 9, 2025
@hayderkg hayderkg deleted the supported-networks-resources branch April 9, 2025 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benface benface benface approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hayderkg @benface @0xa3k5