-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Use the new Firehose info endpoint #5672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mangas
reviewed
Nov 7, 2024
mangas
reviewed
Nov 7, 2024
mangas
approved these changes
Nov 7, 2024
Contributor
mangas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really good work on this PR. Super clean! 🎉
mangas
approved these changes
Nov 12, 2024
128c470 to
5dbd519
Compare
mangas
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the use of the new Firehose Info endpoint. The primary use case for this is provider validation. As a result, the existing provider manager responsible for validating providers has been refactored to support multiple checks. It has also been optimized to rely less on locks, and the number of allocations has been greatly reduced. Also, a new extended blocks check has been added, which requires providers to support extended block details if enabled.
Closes #5673
Todos