all: Defer getting manifest from IPFS when starting subgraph #6170
+16
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current code in `SubgraphAssignmentProvider.start` fetched the manifest from IPFS before starting a subgraph. But the code calling `start`, ultimately `SubgraphRegistrar.start_assigned_subgraphs` waited for all subgraphs to start successfully before processing assignment events. That could lead to a situation where a slow IPFS server, even if it was slow for just one subgraph, could keep a node from processing assignment events. With these changes, interacting with IPFS is deferred to the future that is spawned for running the subgraph so that slow IPFS can slow how long it takes for a subgraph to start, but not the system overall.
isum
approved these changes
Sep 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code in
SubgraphAssignmentProvider.startfetched the manifest from IPFS before starting a subgraph. But the code callingstart, ultimatelySubgraphRegistrar.start_assigned_subgraphswaited for all subgraphs to start successfully before processing assignment events.That could lead to a situation where a slow IPFS server, even if it was slow for just one subgraph, could keep a node from processing assignment events.
With these changes, interacting with IPFS is deferred to the future that is spawned for running the subgraph so that slow IPFS can slow how long it takes for a subgraph to start, but not the system overall.