Asyncify the runtime #6185
Open
Asyncify the runtime #6185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lutter
force-pushed
the
lutter/async-wasm
branch
from
2582eb1 to
897978d
Compare
We need AscHeapCtx to be Send
In particular, that makes the host function stubs in runtime/wasm/src/module/context.rs async which in turn will make it possible to use async implementations in lower levels of the stack, for example, in the store.
lutter
force-pushed
the
lutter/async-wasm
branch
from
897978d to
fc8865f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fact that the runtime wasn't async was a big blocker for making other parts of the code async, especially the store. This PR switches us to using wasmtime in async mode and turns the glue functions in
runtime/wasm/src/module/context.rsinto async functions. Unfortunately, this change is very intrusive as it ultimately requires thatasc_newbecomes async.The PR does not change the thread-per-module execution model for now, even though it would be possible to do that in tokio tasks, simply because it is safer to make that change in isolation at a later time.
The most important things to review are
ToAscPtrimplementations do not change the conversion and layout of data in Assemblyscript