Fix all clippy warnings #6264
Open
Fix all clippy warnings #6264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This applies all clippy lints that are marked as MachineApplicable, i.e., safe to apply without changing code semantics
We need to eventually fix that, but that requires quite a bit of change. For now, we suppress the clippy warning.
Note that that also means that we run 'cargo clippy' in CI because the CI workflow runs 'just lint'
Actually a nice logic error
Note that that also means that we run 'cargo clippy' in CI because the CI workflow runs 'just lint'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes all clippy warnings and requires that 'cargo clippy' passes in CI.
The commits with title "Run 'cargo clippy --fix'" were generated by running just that; since clippy only applies safe mechanical transforms with
--fix, they should not require much review. Most of the other commits are very small and address one specific lint.The first half of the PR (up to the first change to
justfile) only changes actual code since clippy is run against the default target (binary and library)The second half only changes test code by now running
cargo clippy --all-targets