restructure authentication #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikgraf
force-pushed
the
ng/improve-auth-api
branch
from
0279e66 to
3cef29e
Compare
nikgraf
force-pushed
the
ng/improve-auth-api
branch
from
3cef29e to
79ee5c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now we needed a component called
DoGraphLoginthat would run the login directly whenever it was mounted (basically every time).Instead I was aiming for a flow where authentication of Privy and Hypergraph is only happening on the
/loginpage and not implicitly. Unfortunately Privy doesn't provide the necessary APIs for a clean async/await flow, but I at least could manage to isolate the login logic to this page.Next step:
GraphLoginandGraphFrameworkproviderDemo video available here: https://geo-browser.slack.com/archives/C069PB8PCPN/p1737382476074349