Skip to content

Conversation

nikgraf
Copy link
Collaborator

@nikgraf nikgraf commented Jan 21, 2025

  • afaik as of now only react and hypergraph make sense as peerDependency (could be wrong on xstate/store and maybe others?).
  • remove dependencies that are not used in the respective package

@nikgraf nikgraf force-pushed the ng/packages-cleanup branch from c7626de to acf7423 Compare January 21, 2025 14:44
@nikgraf nikgraf requested review from cmwhited and fubhy January 21, 2025 15:19
@nikgraf nikgraf self-assigned this Jan 21, 2025
@nikgraf nikgraf changed the title depedencies cleanup dependencies cleanup Jan 21, 2025
@fubhy fubhy merged commit 273b7ed into main Jan 21, 2025
1 check passed
@fubhy fubhy deleted the ng/packages-cleanup branch January 21, 2025 16:32
"jsdom": "^26.0.0",
"siwe": "^2.3.2",
"viem": "^2.22.9"
"jsdom": "^26.0.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need jsdom still?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, opened a PR here: #115

@nikgraf nikgraf mentioned this pull request Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants