Skip to content

Conversation

@nikgraf
Copy link
Collaborator

@nikgraf nikgraf commented Jan 22, 2025

Do not review or merge yet.

There is still an issue: Login and then visit the login page and refresh. The onComplete callback is ran and fails because wallets are not yet ready. Reached out to the privy team if there is a better way to do this.

@nikgraf nikgraf self-assigned this Jan 22, 2025
@nikgraf nikgraf changed the title use onComplete instead of useEffect Privy login: use onComplete instead of useEffect Jan 22, 2025
@nikgraf
Copy link
Collaborator Author

nikgraf commented Jan 23, 2025

Closing since the Feedback from Privy team was to use a useEffect which we already do.

@nikgraf nikgraf closed this Jan 23, 2025
@nikgraf nikgraf deleted the ng/improve-login branch February 5, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants