entities cache #118
Merged
entities cache #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikgraf
force-pushed
the
entities-cache
branch
3 times, most recently
from
51f5009 to
533a620
Compare
nikgraf
force-pushed
the
entities-cache
branch
from
3c98022 to
646a058
Compare
nikgraf
force-pushed
the
entities-cache
branch
4 times, most recently
from
51f4596 to
75d33e0
Compare
nikgraf
force-pushed
the
entities-cache
branch
from
c8d910b to
4f7c98a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We store all decoded entities in a cache and for each query we reference the entities relevant to this query.
Whenever a query is registered we add it to the cache and add a listener to the query. Whenever a query is registered we remove the listener from the query.
Handling filters should be relatively straight forward as they are uniquely identified by their params.
Currently we only use one global cache for all entities.
In the future we probably want a build function that creates a cache and returns the
functions (create, update, findMany, …) that use this specific cache.
Open questions:
Thoughts: Could be just a special case of findMany limited to a specific id or a separate mechanism.
Thoughts: We could have a separate query entry for each relation, but when requesting a lot of entities e.g. 1000 ly for a nesting one level deep it would result in a lot of cached queries. Not sure this is a good idea.