export only useful functions #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikgraf
commented
Jan 29, 2025
| export { | ||
| HypergraphAppProvider, | ||
| useHypergraphApp, | ||
| useHypergraphAuth, |
There was a problem hiding this comment.
any better ideas for names than useHypergraphApp and useHypergraphAuth?
cmwhited
approved these changes
Jan 30, 2025
|
@cmwhited yeah, I think namespaces make sense when the API gets quite larger e.g. for the core library? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feedback needed here: I was trying out how the API would look like if we only export the Providers and functions we expect developers to use from hypergraph-react.
Benefit: small API surface with nice autocompletion
Downsides: we might not expose stuff people need for edge-cases we don't think about atm