Wallet private key export #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcarranzav
approved these changes
Mar 4, 2025
I would suggest the opposite: whatever we build as the next iteration of identity/auth should support exporting / importing keys. It's an important part of users being true owners of the embedded wallet. |
|
Sounds good to me :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We needed a way for people to use their wallets in node-scripts for https://github.com/graphprotocol/grc-20-ts
Initially tried to use delegation, but realized we can't provide a custom wallet. Can only be the server and this is not what we want. We probably remove this part in the future, but good to have in the demo for now