Public graph integration #154

nikgraf · 2025-03-18T19:31:51Z

No description provided.

Copilot

Pull Request Overview

This PR integrates public graph functionality by introducing smart account wallet client support and updating various entity query and mutation components for public, local, and merged operations. In addition, filter types for entity fields and a new properties/types creation component have been added.

Added support for smart account wallet client integration in public graph operations.
Updated and added new components for user and todo management across different modes (public, local, merged, read-only, filter).
Introduced new type definitions for filters and a component to create properties and types.

Reviewed Changes

Copilot reviewed 82 out of 83 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
apps/events/src/lib/smart-account.ts	Added smart account wallet client integration.
apps/events/src/filter-types.ts	Introduced type definitions for various filter options.
apps/events/src/components/users/*.tsx	Updated user management components across different modes.
apps/events/src/components/todos*.tsx	Integrated public/local todo operations and added new creation/publishing logic.
apps/events/src/components/ui/modal.ts	Added modal component with keyboard support.
apps/events/src/components/create-properties-and-types.tsx	Added a component to create graph properties and types.

Files not reviewed (1)

apps/events/package.json: Language not supported

apps/events/src/components/todos2.tsx

pcarranzav

LGTM!
A few comments but nothing that can't be addressed in separate issues/PRs imo.

I did a very quick pass, so take the review with a grain of salt... a lot of the schema things would take me a lot longer to understand (for instance, no idea what the VariantSchema is).

pcarranzav · 2025-05-02T18:27:31Z

apps/events/src/lib/smart-account.ts

@@ -0,0 +1,14 @@
+import { getSmartAccountWalletClient as grc20getSmartAccountWalletClient } from '@graphprotocol/grc-20';


it would be good to expose this and the other pieces from grc-20 from hypergraph so that users don't need to have grc-20 in their apps... but I guess we can solve this together with the new auth flow

apps/events/src/components/todo/todos-public-kg.tsx

pcarranzav · 2025-05-02T18:41:28Z

apps/events/src/components/todos2.tsx

+    preparePublish: preparePublishUsers,
+  } = useQuery(User);
+  const space = useHypergraphSpace();
+  const createTodo = useCreateEntity(Todo2);


I wonder if it might be nicer to have all these entity actions in a single hook, e.g. const { createEntity: createTodo, updateEntity: updateTodo, deleteEntity: deleteTodo } = useEntityActions(Todo2)?

interesting suggestion, I have no strong opinion here. I'd say let's bring it up in the sync call :)

apps/events/src/filter-types.ts

pcarranzav · 2025-05-02T18:53:15Z

packages/hypergraph-react/src/HypergraphAppContext.tsx

+      let spaceId = Utils.generateId();
+
+      try {
+        if (smartAccountWalletClient?.account) {


Shouldn't public space creation be optional, or are we expecting that private spaces will always have a matching public space? Maybe createSpace could take an options object where we can specify whether it's a public, private or mixed space?
(I imagine there will be a lot of cases where a space is only used for private data sync, and creating a space in the KG would be a waste of resources)

Also, if we're creating private/public spaces with the same ids, I suppose we should also make invitations work for both the public and private space?

yes, I thinks so that it should be possible to create a private space without a public one. And possible create it later. I like the idea of an option. Created an issue here: #170

Yes! invitations should work as well for public spaces #171

pcarranzav · 2025-05-02T19:02:37Z

packages/hypergraph-react/src/create-wallet-client.ts

+
+const DEFAULT_RPC_URL = 'https://rpc-geo-genesis-h0q2s21xx8.t.conduit.xyz';
+
+const GEOGENESIS: Chain = {


Let's have the option, when creating the wallet client, to choose Geo testnet instead?

yeah, if we keep testnet around then it makes sense. Byron mentioned he was about to completely shut it down

pcarranzav · 2025-05-02T19:04:18Z

packages/hypergraph-react/src/internal/create-version-id.ts

+import { md5 } from '@noble/hashes/legacy';
+import { v4 } from 'uuid';
+
+function createIdFromUniqueString(text: string) {


Seems like this file, and a lot of the things in this src/internal folder, could eventually move to the core hypergraph package, right?

spot on, will do this!

pcarranzav · 2025-05-02T19:09:18Z

packages/hypergraph-react/src/publish-ops.ts

+  }
+
+  const cid = await Ipfs.publishEdit({
+    name: 'Update todos',


I imagine this can be a parameter of the function call, or we could use a more generic string?

good catch, added an issue #172

nikgraf added 30 commits March 18, 2025 12:28

first version of merged query

d32cc49

refactor useQuery

4b163dd

add spinner and improve loading experience

2338269

fix test

efe0872

filter out entities marked as deleted from local result

44ec55b

fix linting

01fc533

fix loading experience

bbf9227

fix login behaviour by reseting first and then setting the auth

2158f57

fix types

a86843c

fix delete by using correct endpoint

3082921

invalidate queries after publishing

bb853a7

fix bug filtering out deleted entities

b16b4eb

fix returning multiple entities

0baa851

show deleted local todos

6861e89

fix update

62ccd8c

add prepare publish functionality

133e005

swtich from kg to geo for deleting entities

7c75d65

restructure utilities

d31aacd

expose more information in getDiff

df8ccd0

fix checked state for public queries

413ce3b

create PublishDiff component

ff3b874

add loading states to buttons

2ee0ba1

add type information

3d87051

ignore updates in the __version field

983b992

hotfix the entity type name for the publish diff component

d1d9cdf

only require mapping if in merged mode

d5aa216

split up todos2

1cdc4de

add user mapping

e2399b1

refactor and cleanup diff structure

04e68a6

fix types to pass different entities to the PublishDiff

9faf6d2

update effect packages

59b3ee7

nikgraf force-pushed the ng/public-graph-integration branch from 6a07e3f to 9034a6d Compare April 24, 2025 08:00

wip patching the entity types

f085e63

nikgraf force-pushed the ng/public-graph-integration branch from 9034a6d to 60fe33e Compare April 24, 2025 08:05

nikgraf added 2 commits April 25, 2025 09:24

improve types

6425aec

cleanup types

1be3201

nikgraf force-pushed the ng/public-graph-integration branch 2 times, most recently from 28afc98 to d36ef93 Compare April 28, 2025 15:50

implement include for local & public queries

59a7388

nikgraf force-pushed the ng/public-graph-integration branch from d36ef93 to 0ded21d Compare April 29, 2025 06:41

add more filters

2c4bda7

nikgraf force-pushed the ng/public-graph-integration branch 2 times, most recently from 1c4b753 to e5f6b80 Compare April 29, 2025 14:48

enhance filter capabilities

5a2a3f5

nikgraf force-pushed the ng/public-graph-integration branch from e5f6b80 to 5283c61 Compare April 29, 2025 14:55

Merge branch 'main' into ng/public-graph-integration

1d5d2c5

nikgraf requested review from cmwhited, Copilot and pcarranzav May 2, 2025 12:58

nikgraf self-assigned this May 2, 2025

Copilot AI reviewed May 2, 2025

View reviewed changes

apps/events/src/components/todos2.tsx Show resolved Hide resolved

apps/events/src/components/todos2.tsx Show resolved Hide resolved

nikgraf marked this pull request as ready for review May 2, 2025 13:01

nikgraf mentioned this pull request May 2, 2025

Integrate relation on private & public graph #166

Closed

22 tasks

fix import

e0c822b

pcarranzav approved these changes May 2, 2025

View reviewed changes

nikgraf removed the request for review from cmwhited May 4, 2025 04:35

remove unused filter-types

5910d3b

nikgraf force-pushed the ng/public-graph-integration branch from 7b2d9b1 to 5910d3b Compare May 4, 2025 10:33

nikgraf merged commit d90f819 into main May 4, 2025
4 checks passed

nikgraf deleted the ng/public-graph-integration branch May 4, 2025 10:37

		@@ -0,0 +1,14 @@
		import { getSmartAccountWalletClient as grc20getSmartAccountWalletClient } from '@graphprotocol/grc-20';


		const DEFAULT_RPC_URL = 'https://rpc-geo-genesis-h0q2s21xx8.t.conduit.xyz';

		const GEOGENESIS: Chain = {

Public graph integration #154

Public graph integration #154

Uh oh!

Conversation

nikgraf commented Mar 18, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

pcarranzav left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants