upgrade dependencies and generate Prisma client to custom path #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcarranzav
approved these changes
May 6, 2025
| // TODO: Using `pnpm deploy` with prisma is quite annoying. We should consider generating the prisma client into | ||
| // a directory within the package here instead of generating it into node modules (default). | ||
| provider = "prisma-client-js" | ||
| output = "generated/client" |
There was a problem hiding this comment.
Should the TODO comment above be removed now?
There was a problem hiding this comment.
great catch, I removed it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the upgrade you must regenerate the prisma client e.g. using
cd apps/server pnpm prisma migrate devDependencies I didn't upgrade and would do in separate PRs: