Skip to content

Conversation

nikgraf
Copy link
Collaborator

@nikgraf nikgraf commented May 8, 2025

  1. I was wonder why biome lint issues sometimes pass CI. Realized we use the write on CI and then it the CI process doesn't fail.
  2. Fixed the remaining lint/format issues
  3. There was a custom biome config in the events app, but not sure if any of the overwrites had real impact or basically resulted in the same config as the inherited one. When running lint/format there are 0 warnings/errors. I tested with a useEffect hook errors which work in the editor and the CLI.

Over the past couple months I regularly had issues with Biome in Cursor. Wiping the cache now seems to work better biomejs/biome-vscode#25 (comment)

solves #111

@nikgraf nikgraf requested review from cmwhited and pcarranzav May 8, 2025 08:31
@nikgraf nikgraf self-assigned this May 8, 2025
@nikgraf nikgraf merged commit 7adf82d into main May 8, 2025
4 checks passed
@nikgraf nikgraf deleted the ng/cleanup-biome-config branch May 8, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants