Skip to content

Conversation

nikgraf
Copy link
Collaborator

@nikgraf nikgraf commented May 14, 2025

I upgrade Prisma and the node_modules based client generation was deprecated. I moved the generation to the prisma folder, but forgot the docker setup.

With the new client they simply generate TypeScript files with import statements. This means we can include it like any other code we have in our repository.

@nikgraf nikgraf requested review from Copilot, fubhy and pcarranzav May 14, 2025 07:02
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the server setup by updating the Prisma client generation configuration and adjusting the Dockerfile to accommodate the new TypeScript-based client.

  • Updated the Prisma generator configuration in schema.prisma (changed provider and added moduleFormat).
  • Modified the Dockerfile to run client generation during the build process and removed the redundant generation step in the deployment folder.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
apps/server/prisma/schema.prisma Updates to the generator configuration to use the new Prisma client and ESM output.
Dockerfile Adjustments to include client generation during build and removal of legacy steps.
Comments suppressed due to low confidence (1)

Dockerfile:34

  • Verify that generating the Prisma client at this stage covers all production requirements, as the legacy generation in the deployment folder has been removed.
pnpm --filter server prisma generate && \

output = "generated/client"
provider = "prisma-client"
output = "generated/client"
moduleFormat = "esm"
Copy link

Copilot AI May 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider adding a brief comment explaining the purpose of setting 'moduleFormat' to 'esm' to provide clarity on its role in the new Prisma client generation workflow.

Copilot uses AI. Check for mistakes.

@nikgraf nikgraf merged commit 6d7831c into main May 14, 2025
4 checks passed
@nikgraf nikgraf deleted the fix-server-setup branch May 14, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant