add connect app scaffold #189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmwhited
approved these changes
May 14, 2025
apps/connect/index.html
Outdated
| <meta charset="UTF-8" /> | ||
| <link rel="icon" type="image/svg+xml" href="/vite.svg" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>Vite + React + TS</title> |
There was a problem hiding this comment.
Nitpick. But we probably want to add a correct title and description to get at least some amount of SEO. (Can work on this later when we have a logo, etc)
apps/connect/public/vite.svg
Outdated
There was a problem hiding this comment.
gonna guess we probably don't want to keep this
apps/connect/src/main.tsx
Outdated
|
|
||
| // biome-ignore lint/style/noNonNullAssertion: root element is always there | ||
| createRoot(document.getElementById('root')!).render( | ||
| // <StrictMode> |
There was a problem hiding this comment.
Just curious, why no <StrictMode>?
There was a problem hiding this comment.
good point, will add it
pcarranzav
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting up a simple "Connect" app boilerplate
I went with Tanstack router for now as it seems to be cleanest solution in terms of typing and simple features we need.