feat(typesync | create app form): switch to use @tanstack/react-form. component cleanup #204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… component cleanup
|
@cmwhited is attempting to deploy a commit to the The Graph Foundation team on Vercel, but is not a member of this team. To resolve this issue, you can:
To read more about collaboration on Vercel, click here. |
cmwhited
commented
Jun 3, 2025
Comment on lines
-16
to
+30
| case typeName === 'Text': | ||
| case type_name === 'Text': | ||
| return 'Type.Text'; | ||
| case typeName === 'Number': | ||
| case type_name === 'Number': | ||
| return 'Type.Number'; | ||
| case typeName === 'Boolean': | ||
| case type_name === 'Boolean': | ||
| return 'Type.Boolean'; | ||
| case typeName === 'Date': | ||
| case type_name === 'Date': | ||
| return 'Type.Date'; | ||
| case typeName === 'Url': | ||
| case type_name === 'Url': | ||
| return 'Type.Url'; | ||
| case typeName === 'Point': | ||
| case type_name === 'Point': | ||
| return 'Type.Point'; | ||
| case typeName.startsWith('Relation'): | ||
| case type_name.startsWith('Relation'): | ||
| // renders the type as `Type.Relation(Entity)` | ||
| return `Type.${typeName}`; | ||
| return `Type.${type_name}`; |
There was a problem hiding this comment.
@nikgraf one of my follow-up PRs will be to update the schema type to come over as camelCase, instead of snake_case when the data is pulled from the database. When I do that, this will be updated.
There was a problem hiding this comment.
👍 btw also fine to keep snake case if there is a good reason. just was curious
nikgraf
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Switch from
react-hook-formto @tanstack/react-form. We use tanstack for both the router and the query layer. Made a lot of sense to also use their form library. Also, the api is much cleaner/nicer work with thanreact-hook-formwhere I kept running into issues, especially with nested arrays, etc.Also did a pretty big cleanup of the files/components for a cleaner/more understandable approach.
Notes
SchemaBrowserfrom the schema builder step in the form as my next PR is to move to the geo indexer with updated queries. Once I complete that work, I will bring theSchemaBrowserback in and fix selecting types/properties from the browser into the schema