-
Notifications
You must be signed in to change notification settings - Fork 8
add signup and managing spaces in connect app #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
b38d376
to
a3d4591
Compare
a3d4591
to
38f33b0
Compare
38f33b0
to
9b8fd31
Compare
9b8fd31
to
33d775e
Compare
33d775e
to
a9e20a6
Compare
a9e20a6
to
a0daa2a
Compare
a0daa2a
to
e1e4eb7
Compare
e1e4eb7
to
5890f92
Compare
5890f92
to
2882642
Compare
18f8f82
to
1687b88
Compare
1687b88
to
106d6a0
Compare
106d6a0
to
79e652b
Compare
79e652b
to
93dc741
Compare
93dc741
to
d8c1ee9
Compare
d8c1ee9
to
8595257
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the deprecated wallet export feature from the Events app, updates its routing to include an authentication success page, and fully integrates Hypergraph‐based authentication and space management in the Connect app.
- Events app
- Adds
/authenticate-success
route and skips redirect there - Removes the export‐wallet link and Privy context provider
- Displays full user address instead of truncated account ID
- Adds
- Connect app
- Implements Privy + Hypergraph login flow (auto‐login on mount)
- Adds space creation and listing components communicating with the Connect API
- Updates routing, Vite, and TypeScript configs for new endpoints
Reviewed Changes
Copilot reviewed 137 out of 137 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
apps/events/src/routes/__root.tsx | Adjusted redirect logic and replaced truncated ID with address |
apps/events/src/Boot.tsx | Removed PrivyProvider wrapper (authentication context) |
apps/connect/src/routes/login.lazy.tsx | Extended Privy login effect to auto-authenticate with Hypergraph |
apps/connect/src/components/create-space.tsx | New CreateSpace component with loading state and fetch logic |
apps/connect/src/components/spaces.tsx | New Spaces component to list existing spaces |
apps/connect/src/routeTree.gen.ts | Added /authenticate virtual route for the Connect app |
Comments suppressed due to low confidence (1)
apps/events/src/Boot.tsx:2
- The PrivyProvider was removed, but components like login and logout still depend on usePrivy. Wrap the app in PrivyProvider (or another auth provider) so usePrivy hooks have context.
import { HypergraphAppProvider } from '@graphprotocol/hypergraph-react';
const createSpace = async () => { | ||
setIsLoading(true); | ||
if (!accountAddress || !keys || !identityToken) { | ||
console.error('Missing required fields', { accountAddress, keys, identityToken }); |
Copilot
AI
Jun 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Early return on missing fields leaves isLoading
set to true. Move setIsLoading(false)
into this branch or wrap the function body in a try
/finally
to always reset loading.
console.error('Missing required fields', { accountAddress, keys, identityToken }); | |
console.error('Missing required fields', { accountAddress, keys, identityToken }); | |
setIsLoading(false); |
Copilot uses AI. Check for mistakes.
queryKey: ['spaces'], | ||
queryFn: async () => { | ||
if (!identityToken) return; | ||
const response = await fetch('http://localhost:3030/connect/spaces', { |
Copilot
AI
Jun 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hardcoded API endpoint URL. Extract the base URI to an environment variable or shared config to ease future changes and environment switching.
const response = await fetch('http://localhost:3030/connect/spaces', { | |
const response = await fetch(`${process.env.REACT_APP_API_BASE_URL}/connect/spaces`, { |
Copilot uses AI. Check for mistakes.
name: spaceName, | ||
}; | ||
|
||
const response = await fetch('http://localhost:3030/connect/spaces', { |
Copilot
AI
Jun 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hardcoded fetch URL—consider using an env var (e.g. import.meta.env.VITE_API_BASE
) or a shared HTTP client for consistency with other calls.
Copilot uses AI. Check for mistakes.
8595257
to
d050c01
Compare
No description provided.