fix(typesync | publish): tsup and package.json updates for publishing #218
Conversation
|
@cmwhited is attempting to deploy a commit to the The Graph Foundation team on Vercel, but is not a member of this team. To resolve this issue, you can:
To read more about collaboration on Vercel, click here. |
marcusrein
force-pushed
the
chris.whited/fix-published-pkg
branch
from
d1f6ee1 to
93f0ad8
Compare
Update
All CI checks now pass and Vercel previews are green. Ready to squash-and-merge. |
| # Generate the prisma client | ||
| pnpm --filter server prisma generate && \ | ||
| # Build the monorepo packages | ||
| pnpm build && \ |
There was a problem hiding this comment.
are these changes necessary? according to https://geo-browser.slack.com/archives/C069PB8PCPN/p1750368390845489?thread_ts=1746676932.512389&cid=C069PB8PCPN the server is working fine
There was a problem hiding this comment.
@cmwhited can you revert this change? The dockerfile works and only want to make changes where necessary
apps/server/tsup.config.ts
Outdated
| format: ['esm'], | ||
| clean: true, | ||
| sourcemap: true, | ||
| external: ['../prisma/generated/client'], |
There was a problem hiding this comment.
are these changes necessary? according to https://geo-browser.slack.com/archives/C069PB8PCPN/p1750368390845489?thread_ts=1746676932.512389&cid=C069PB8PCPN the server is working fine
apps/typesync/package.json
Outdated
| "@graphprotocol/grc-20": "^0.21.2", | ||
| "@graphql-codegen/cli": "^5.0.6", | ||
| "@graphql-codegen/client-preset": "^4.8.1", | ||
| "@graphprotocol/grc-20": "^0.18.0", |
There was a problem hiding this comment.
we should not downgrade grc-20 here
….whited/fix-published-pkg
… sql output, making it hidden
cmwhited
changed the title
apps/server/prisma/schema.prisma
Outdated
| provider = "prisma-client" | ||
| output = "generated/client" | ||
| moduleFormat = "esm" | ||
| provider = "prisma-client-js" |
There was a problem hiding this comment.
@cmwhited can you revert this change? The sync server is working fine for me locally and on fly.io. This change might break it and revert back to the old prisma client
| '@graphprotocol/hypergraph-react': | ||
| 'https://pkg.pr.new/graphprotocol/hypergraph/@graphprotocol/hypergraph-react@82b867a', | ||
| '@graphprotocol/hypergraph': '@graphprotocol/hypergraph', | ||
| '@graphprotocol/hypergraph-react': '@graphprotocol/hypergraph-react', |
There was a problem hiding this comment.
shouldn't this be a hard-coded version number that we also keep in sync with the published version, same for the file above
3 participants
Description
Making updates to
typesyncto make it a publishable cli package.esmand handle dynamic imports@graphprototol/typesync-cliis now a published package in npm and installable and runnable as a cli. But it has some issues:distseems to not be able to be found when running the cli after installingtypesync studio. not sure the issue, assumed since themigrationsdirectory came over as expected, so would the/client/dist/files.typesync.dbfor sqlite on the users machine. this might be fine. but wonder if we should make it as.typesync.dbso that it is hidden by default?