use space name for spaces list #234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates the handling of space data to include a human-readable name in the spaces list.
- Adds a new "name" property to the SpaceStorageEntry type and updates the setSpaceFromList event.
- Updates the message schema and frontend components to use the space name instead of the space id for display.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/hypergraph/src/store.ts | Added the "name" property; updated setSpaceFromList event structure and usage in space updating logic. |
| packages/hypergraph/src/messages/types.ts | Extended the list spaces response schema to include space names. |
| packages/hypergraph-react/src/HypergraphAppContext.tsx | Modified event dispatch to include the space name. |
| apps/events/src/routes/index.tsx | Updated UI elements to display space.name in place of space.id. |
| if (existingSpace.id === event.spaceId) { | ||
| const newSpace: SpaceStorageEntry = { | ||
| id: existingSpace.id, | ||
| name: existingSpace.name, |
There was a problem hiding this comment.
In the existing space update logic, the event carries a new name but the code reuses the existing space name. Consider using event.name to update the space name consistently.
Suggested change
| name: existingSpace.name, | |
| name: event.name, |
Copilot uses AI. Check for mistakes.
nikgraf
force-pushed
the
ng/use-space-name-for-spaces-list
branch
from
65d776f to
4275416
Compare
nikgraf
force-pushed
the
ng/use-space-name-for-spaces-list
branch
from
4275416 to
643945e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.