Skip to content

fix: restore signature verification #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025
Merged

fix: restore signature verification #252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion apps/server/.env.example
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
DATABASE_URL="file:./dev.db"
PRIVY_APP_SECRET="TODO"
PRIVY_APP_ID="TODO"
PRIVY_APP_ID="TODO"
HYPERGRAPH_CHAIN="geogenesis"
78 changes: 40 additions & 38 deletions packages/hypergraph/src/identity/prove-ownership.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
//import { http, type Chain, type Hex, type WalletClient, createPublicClient, verifyMessage } from 'viem';
import type { Chain, Hex, WalletClient } from 'viem';
import { http, type Chain, type Hex, type WalletClient, createPublicClient, verifyMessage } from 'viem';
import { privateKeyToAccount } from 'viem/accounts';

import type { SmartAccountClient } from 'permissionless';
import { DEFAULT_RPC_URL, GEOGENESIS } from '../connect/smart-account.js';
//import { publicKeyToAddress } from '../utils/index.js';
import { publicKeyToAddress } from '../utils/index.js';
import type { IdentityKeys } from './types.js';

export const getAccountProofMessage = (accountAddress: string, publicKey: string): string => {
Expand Down Expand Up @@ -60,43 +59,46 @@ export const verifyIdentityOwnership = async (
rpcUrl: string = DEFAULT_RPC_URL,
): Promise<boolean> => {
console.log('verifyIdentityOwnership', accountAddress, publicKey, accountProof, keyProof, chain, rpcUrl);
// const keyProofMessage = getKeyProofMessage(accountAddress, publicKey);
// const publicClient = createPublicClient({
// chain,
// transport: http(rpcUrl),
// });
const keyProofMessage = getKeyProofMessage(accountAddress, publicKey);
const publicClient = createPublicClient({
chain,
transport: http(rpcUrl),
});
console.log('publicClient', publicClient);
console.log('rpcUrl', rpcUrl);
console.log('chain', chain);

// console.log('accountProof', accountProof);
// console.log('accountAddress', accountAddress);
// console.log('publicKey', publicKey);
console.log('accountProof', accountProof);
console.log('accountAddress', accountAddress);
console.log('publicKey', publicKey);

// const accountProofMessage = getAccountProofMessage(accountAddress, publicKey);
// const validAccountProof = await publicClient.verifyTypedData({
// address: accountAddress as Hex,
// message: {
// message: accountProofMessage,
// },
// types: {
// Message: [{ name: 'message', type: 'string' }],
// },
// domain: accountProofDomain,
// primaryType: 'Message',
// signature: accountProof as Hex,
// });
// if (!validAccountProof) {
// console.log('Invalid account proof');
// return false;
// }
const accountProofMessage = getAccountProofMessage(accountAddress, publicKey);
const validAccountProof = await publicClient.verifyTypedData({
address: accountAddress as Hex,
message: {
message: accountProofMessage,
},
types: {
Message: [{ name: 'message', type: 'string' }],
},
domain: accountProofDomain,
primaryType: 'Message',
signature: accountProof as Hex,
});
if (!validAccountProof) {
console.log('Invalid account proof');
return false;
}

// const keyAddress = publicKeyToAddress(publicKey) as Hex;
// const validKeyProof = await verifyMessage({
// address: keyAddress,
// message: keyProofMessage,
// signature: keyProof as Hex,
// });
// if (!validKeyProof) {
// console.log('Invalid key proof');
// return false;
// }
const keyAddress = publicKeyToAddress(publicKey) as Hex;
const validKeyProof = await verifyMessage({
address: keyAddress,
message: keyProofMessage,
signature: keyProof as Hex,
});
if (!validKeyProof) {
console.log('Invalid key proof');
return false;
}
return true;
};
Loading