[WIP] feat(TS builds): move off vite for builds and use updated tsconfig instead #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikgraf
force-pushed
the
chris.whited/feat-ts-builds
branch
from
7eb6b0b to
8d5bbb4
Compare
|
@fubhy is not available next week afaik one more thing we need to fix is |
nikgraf
reviewed
Nov 10, 2024
| export default defineConfig({ | ||
| plugins: [react()], | ||
| test: { | ||
| globals: true, |
There was a problem hiding this comment.
Do we need the globals here?
There was a problem hiding this comment.
I'd also suggest to not use globals.
fubhy
requested changes
Nov 26, 2024
Comment on lines
+2
to
4
| return JSON.parse(data, (__key, value) => { | ||
| if (typeof value === 'object' && value !== null && value.type === 'Uint8Array') { | ||
| return new Uint8Array(value.data); |
Comment on lines
+3
to
5
| return JSON.stringify(data, (_key, value) => { | ||
| if (value instanceof Uint8Array) { | ||
| return { type: 'Uint8Array', data: Array.from(value) }; |
| const connectWallet = async () => { | ||
| let newSigner = null; | ||
| let provider; | ||
| let provider: ethers.AbstractProvider | ethers.BrowserProvider; |
There was a problem hiding this comment.
Can we use Viem instead of Ethers? https://github.com/wevm/viem
Or maybe even go as low as Ox? https://github.com/wevm/ox
| export default defineConfig({ | ||
| plugins: [react()], | ||
| test: { | ||
| globals: true, |
There was a problem hiding this comment.
I'd also suggest to not use globals.
| }, | ||
| "pnpm": { | ||
| "patchedDependencies": { | ||
| "[email protected]": "patches/[email protected]" |
There was a problem hiding this comment.
We'll also need to remember to add the changeset patches. Otherwise every minor or patch bump of a dependent package will cause a major version increment.
|
Closing in favor of new tsconfig PR created by Nik |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moved to using better tsconfigs with paths, references, etc for "builds".
This came from this comment on #22.
Notes
I basically ended up copying the structure that effect uses for tsconfigs and builds. It seems to mostly work within the packages, but the
apps/eventsis broken sayingCannot find module 'graph-framework' or its corresponding type declarations.. I could use some help with this as I am not sure what I am missing?? cc @nikgraf @fubhy (who still needs repo access). Maybe we can chat Monday on it and go through some options.