Skip to content

Conversation

nikgraf
Copy link
Collaborator

@nikgraf nikgraf commented Jul 2, 2025

closes #301

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds logic to skip types and properties without a knowledgeGraphId when generating the mapping file and includes tests to verify skipping type entries without IDs.

  • Added continue checks in buildMappingFile to omit types and properties lacking knowledgeGraphId
  • Introduced two tests in Generator.test.ts for skipping entries without IDs

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
apps/typesync/src/Generator.ts Skip types and properties without knowledgeGraphId
apps/typesync/test/Generator.test.ts Tests for skipping mapping entries with missing IDs
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (2)

apps/typesync/test/Generator.test.ts:132

  • The second it block has the same description as the previous test. Consider renaming it to something like 'should skip property entries without a knowledgeGraphId' to clarify its purpose.
  it('should skip a type entry without a knowledgeGraphId', () => {

apps/typesync/src/Generator.ts:381

  • Consider adding a dedicated test to verify that relation entries with a null or missing knowledgeGraphId are also skipped, ensuring the skip logic covers both properties and relations.
      if (!property.knowledgeGraphId) {

@nikgraf nikgraf force-pushed the ng/filter-mapping branch from 77cada6 to 9f105dd Compare July 2, 2025 19:38
@nikgraf nikgraf merged commit a61359c into main Jul 2, 2025
6 checks passed
@nikgraf nikgraf deleted the ng/filter-mapping branch July 2, 2025 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(TypeSync) Filter out mapping for types and properties that don't have an ID

1 participant