Skip to content

sign events with the account and verify them before applying them #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2024
Merged

sign events with the account and verify them before applying them #36

merged 1 commit into from
Nov 13, 2024

Conversation

nikgraf
Copy link
Collaborator

@nikgraf nikgraf commented Nov 12, 2024 •
edited
Loading

  • Adding privateKeys to accounts. They public key becomes their id
  • Signing all event transactions and verifying them on the server and in the tests
  • Migrated all space events to be an effect for better error handling

@nikgraf nikgraf requested a review from cmwhited November 12, 2024 11:11
cmwhited
cmwhited approved these changes Nov 12, 2024
View reviewed changes
packages/graph-framework-utils/src/stringToUint8Array.ts
@@ -0,0 +1,5 @@
const encoder = new TextEncoder();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this work on node and ReactNative envs? When I was working on the generateId I read about TextEncoder and it was mentioned it doesn't always work on ReactNative?? Maybe it needs a polyfill?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spot on question 👏 This was a problem in the past, but from Expo SDK 51 (React Native 74), Hermes supports TextEncoder natively.

Source: https://github.com/EvanBacon/text-decoder

@nikgraf nikgraf merged commit 1fbec34 into main Nov 13, 2024
1 check passed
@nikgraf nikgraf deleted the sign-and-verify-space-events branch November 13, 2024 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cmwhited cmwhited cmwhited approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nikgraf @cmwhited