Invite account #39
Merged
Invite account #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
nikgraf
commented
Nov 14, 2024
nikgraf
commented
- Cleanup inviting another account
- Listing invitations
- Cleanup playground UI (showing debugging UI)
nikgraf
force-pushed
the
invite-account
branch
from
41e28d5 to
eefd081
Compare
cmwhited
approved these changes
Nov 14, 2024
| }); | ||
|
|
||
| return result.map((invitation) => { | ||
| const state = JSON.parse(invitation.space.events[0].state) as SpaceState; |
There was a problem hiding this comment.
Just curious, could we use the effect Schema handling to encode/decode and validate the space object instead of type-casting? (I am learning effect more and more, so could be wrong here, but seems safer?)
There was a problem hiding this comment.
good catch! yeah, when I wrote the code I thought: this always only can be a valid state. But you are right! better to be safe than sorry :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.