disable signing UI #430
Merged
disable signing UI #430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR disables the wallet UI for signing operations in the login flow by adding a configuration option to suppress UI dialogs.
- Adds
uiOptions: { showWalletUIs: false }parameter to thesignMessagecall for Privy wallet clients
Comments suppressed due to low confidence (1)
apps/connect/src/routes/login.lazy.tsx:39
- There's a naming conflict where the async function parameter
signMessageshadows the importedsignMessagefunction being called. Consider renaming the function parameter to avoid confusion.
const { signature } = await signMessage({ message }, { uiOptions: { showWalletUIs: false } });
nikgraf
force-pushed
the
ng/disable-signin-ui
branch
from
d4718b7 to
79955d4
Compare
|
Pablo approved in a direct conversation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.