-
Notifications
You must be signed in to change notification settings - Fork 8
improve filters #454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve filters #454
Conversation
dd885e7
to
55d04c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR improves filter logic to match public filter logic by restricting logical operators ('not', 'or') to only be allowed at the cross-field level, preventing their use within individual field filters.
- Adds validation to throw errors when logical operators are used at the field level
- Removes the 'and' operator restriction and simplifies filter evaluation logic
- Improves error handling by re-throwing filter validation errors
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
packages/hypergraph/src/entity/findMany.ts | Updates filter evaluation logic to restrict logical operators and improves error handling |
packages/hypergraph/test/entity/findMany.test.ts | Adds new test cases for field-level logical operator validation and updates existing tests |
.changeset/mighty-numbers-run.md | Adds changeset documentation for the filter logic improvements |
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
rework filter logic to match public filter logic
follow up to #442