Skip to content

Conversation

nikgraf
Copy link
Collaborator

@nikgraf nikgraf commented Aug 11, 2025

No description provided.

@nikgraf nikgraf requested a review from Copilot August 11, 2025 11:49
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the explore public knowledge page to support multiple dataset types through a tabbed interface and adds new entity schemas for a more comprehensive knowledge graph.

Key changes:

  • Added new entity schemas (Dapp, Investor, FundingStage, InvestmentRound, Asset) to support broader dataset exploration
  • Refactored explore-public-knowledge into a layout with child routes for different dataset types
  • Implemented tabbed navigation for switching between Projects, dApps, Investment Rounds, and Asset Market

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 13 comments.

Show a summary per file
File Description
schema.ts Added new entity class definitions for Dapp, Investor, FundingStage, InvestmentRound, and Asset
routes/index.tsx Updated start exploring link to point to projects tab
routes/explore-public-knowledge/projects.tsx Extracted existing projects page with search functionality
routes/explore-public-knowledge/investment-rounts.tsx New page for displaying investment rounds data
routes/explore-public-knowledge/index.tsx Added redirect from base path to projects tab
routes/explore-public-knowledge/dapps.tsx New page for displaying dApps with GitHub integration
routes/explore-public-knowledge/asset-market.tsx New page for displaying asset market data
routes/explore-public-knowledge.tsx Refactored to layout component with tabbed navigation
routeTree.gen.ts Auto-generated route tree updates for new child routes
mapping.ts Added entity mappings for new schema classes
components/navbar.tsx Updated navigation link to point to projects tab
components/explore-tabs.tsx New tabbed navigation component for dataset switching

<span className="text-white font-bold text-lg">{investmentRound.name.charAt(0).toUpperCase()}</span>
</div>

{/* Asset name */}
Copy link

Copilot AI Aug 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment says 'Asset name' but this is displaying an investment round name, not an asset name.

Suggested change
{/* Asset name */}
{/* Investment round name */}

Copilot uses AI. Check for mistakes.

{investmentRound.name}
</h3>

{/* Asset ID */}
Copy link

Copilot AI Aug 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment says 'Asset ID' but this is displaying an investment round ID, not an asset ID.

Suggested change
{/* Asset ID */}
{/* Investment Round ID */}

Copilot uses AI. Check for mistakes.

Comment on lines 94 to 95
<h3 className="text-xl font-semibold text-gray-900 mb-2">No Projects Found</h3>
<p className="text-gray-500">There are currently no public projects available to explore.</p>
Copy link

Copilot AI Aug 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The empty state message says 'No Projects Found' but this page displays investment rounds, not projects.

Suggested change
<h3 className="text-xl font-semibold text-gray-900 mb-2">No Projects Found</h3>
<p className="text-gray-500">There are currently no public projects available to explore.</p>
<h3 className="text-xl font-semibold text-gray-900 mb-2">No Investment Rounds Found</h3>
<p className="text-gray-500">There are currently no public investment rounds available to explore.</p>

Copilot uses AI. Check for mistakes.

Comment on lines 94 to 95
<h3 className="text-xl font-semibold text-gray-900 mb-2">No Projects Found</h3>
<p className="text-gray-500">There are currently no public projects available to explore.</p>
Copy link

Copilot AI Aug 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The empty state description mentions 'projects' but should reference 'investment rounds' for consistency with the page content.

Suggested change
<h3 className="text-xl font-semibold text-gray-900 mb-2">No Projects Found</h3>
<p className="text-gray-500">There are currently no public projects available to explore.</p>
<h3 className="text-xl font-semibold text-gray-900 mb-2">No Investment Rounds Found</h3>
<p className="text-gray-500">There are currently no public investment rounds available to explore.</p>

Copilot uses AI. Check for mistakes.

Comment on lines 113 to 114
<h3 className="text-xl font-semibold text-gray-900 mb-2">No Projects Found</h3>
<p className="text-gray-500">There are currently no public projects available to explore.</p>
Copy link

Copilot AI Aug 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The empty state message says 'No Projects Found' but this page displays dApps, not projects.

Suggested change
<h3 className="text-xl font-semibold text-gray-900 mb-2">No Projects Found</h3>
<p className="text-gray-500">There are currently no public projects available to explore.</p>
<h3 className="text-xl font-semibold text-gray-900 mb-2">No Dapps Found</h3>
<p className="text-gray-500">There are currently no public dapps available to explore.</p>

Copilot uses AI. Check for mistakes.

Comment on lines 113 to 114
<h3 className="text-xl font-semibold text-gray-900 mb-2">No Projects Found</h3>
<p className="text-gray-500">There are currently no public projects available to explore.</p>
Copy link

Copilot AI Aug 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The empty state description mentions 'projects' but should reference 'dApps' for consistency with the page content.

Suggested change
<h3 className="text-xl font-semibold text-gray-900 mb-2">No Projects Found</h3>
<p className="text-gray-500">There are currently no public projects available to explore.</p>
<h3 className="text-xl font-semibold text-gray-900 mb-2">No dApps Found</h3>
<p className="text-gray-500">There are currently no public dApps available to explore.</p>

Copilot uses AI. Check for mistakes.

@nikgraf nikgraf merged commit b2fbdbb into main Aug 11, 2025
6 checks passed
@nikgraf nikgraf deleted the ng/add-datasets branch August 11, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant