fix initial typesync sse #484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l message is the second one and the browser receives it
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue with Server-Sent Events (SSE) in the Typesync service where browsers don't receive the initial message. The fix adds a workaround that sends an empty message first, ensuring the actual first message is delivered to the browser.
- Adds an empty SSE message as a workaround for browser SSE message delivery issues
- Updates the changeset to document the schema loading fix
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/hypergraph/src/cli/services/Typesync.ts | Implements SSE workaround by prepending an empty message to the stream |
| .changeset/hungry-monkeys-shine.md | Documents the fix for initial schema loading in typesync |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| const sseData = `data: ${jsonData}\n\n`; | ||
| return encoder.encode(sseData); | ||
| }), | ||
| ), |
There was a problem hiding this comment.
The hardcoded empty message should be extracted to a constant or generated using the same logic as the actual messages to maintain consistency and avoid magic strings.
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.