Skip to content

improve server logging #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 15, 2025
Merged

improve server logging #485

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85d4a3e
improve server logging
nikgraf Aug 15, 2025
6b48054
cleanup
nikgraf Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 31 additions & 6 deletions apps/server/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -797,38 +797,46 @@ webSocketServer.on('connection', async (webSocket: CustomWebSocket, request: Req

console.log('Connection established', accountAddress);
webSocket.on('message', async (message) => {
console.log('Received websocket message');
try {
const rawData = Messages.deserialize(message.toString());
const result = decodeRequestMessage(rawData);
if (result._tag === 'Right') {
const data = result.right;
switch (data.type) {
case 'subscribe-space': {
console.log('--- Received subscribe-space message');
const space = await getSpace({ accountAddress, spaceId: data.id, appIdentityAddress });
const outgoingMessage: Messages.ResponseSpace = {
...space,
type: 'space',
};
webSocket.subscribedSpaces.add(data.id);
webSocket.send(Messages.serialize(outgoingMessage));
console.log('--- Sent subscribe-space response');
break;
}
case 'list-spaces': {
console.log('--- Received list-spaces message');
const spaces = await listSpacesByAppIdentity({ appIdentityAddress });
const outgoingMessage: Messages.ResponseListSpaces = { type: 'list-spaces', spaces: spaces };
webSocket.send(Messages.serialize(outgoingMessage));
console.log('--- Sent list-spaces response');
break;
}
case 'list-invitations': {
console.log('--- Received list-invitations message');
const invitations = await listInvitations({ accountAddress });
const outgoingMessage: Messages.ResponseListInvitations = {
type: 'list-invitations',
invitations: invitations,
};
webSocket.send(Messages.serialize(outgoingMessage));
console.log('--- Sent list-invitations response');
break;
}
case 'create-space-event': {
console.log('--- Received create-space-event message');
const getVerifiedIdentity = (accountAddressToFetch: string, publicKey: string) => {
if (accountAddressToFetch !== accountAddress) {
return Effect.fail(new Identity.InvalidIdentityError());
Expand Down Expand Up @@ -867,14 +875,16 @@ webSocketServer.on('connection', async (webSocket: CustomWebSocket, request: Req
type: 'space',
};
webSocket.send(Messages.serialize(outgoingMessage));
console.log('--- Sent create-space-event response');
} else {
console.log('Failed to apply create space event');
console.log('--- Failed to apply create space event');
console.log(applyEventResult);
}
// TODO send back error
break;
}
case 'create-invitation-event': {
console.log('--- Received create-invitation-event message');
await applySpaceEvent({
accountAddress,
spaceId: data.spaceId,
Expand All @@ -887,6 +897,7 @@ webSocketServer.on('connection', async (webSocket: CustomWebSocket, request: Req
type: 'space',
};
webSocket.send(Messages.serialize(outgoingMessage));
console.log('--- Sent create-invitation-event response');
for (const client of webSocketServer.clients as Set<CustomWebSocket>) {
if (
client.readyState === WebSocket.OPEN &&
Expand All @@ -906,17 +917,20 @@ webSocketServer.on('connection', async (webSocket: CustomWebSocket, request: Req
break;
}
case 'accept-invitation-event': {
console.log('--- Received accept-invitation-event message');
await applySpaceEvent({ accountAddress, spaceId: data.spaceId, event: data.event, keyBoxes: [] });
const spaceWithEvents = await getSpace({ accountAddress, spaceId: data.spaceId, appIdentityAddress });
const outgoingMessage: Messages.ResponseSpace = {
...spaceWithEvents,
type: 'space',
};
webSocket.send(Messages.serialize(outgoingMessage));
console.log('--- Sent accept-invitation-event response');
broadcastSpaceEvents({ spaceId: data.spaceId, event: data.event, currentClient: webSocket });
break;
}
case 'create-space-inbox-event': {
console.log('--- Received create-space-inbox-event message');
await applySpaceEvent({ accountAddress, spaceId: data.spaceId, event: data.event, keyBoxes: [] });
const spaceWithEvents = await getSpace({ accountAddress, spaceId: data.spaceId, appIdentityAddress });
// TODO send back confirmation instead of the entire space
Expand All @@ -925,10 +939,12 @@ webSocketServer.on('connection', async (webSocket: CustomWebSocket, request: Req
type: 'space',
};
webSocket.send(Messages.serialize(outgoingMessage));
console.log('--- Sent create-space-inbox-event response');
broadcastSpaceEvents({ spaceId: data.spaceId, event: data.event, currentClient: webSocket });
break;
}
case 'create-account-inbox': {
console.log('--- Received create-account-inbox message');
try {
// Check that the signature is valid for the corresponding accountAddress
if (data.accountAddress !== accountAddress) {
Expand All @@ -947,12 +963,14 @@ webSocketServer.on('connection', async (webSocket: CustomWebSocket, request: Req
// Broadcast the inbox to other clients from the same account
broadcastAccountInbox({ inbox: data });
} catch (error) {
console.error('Error creating account inbox:', error);
console.error('--- Error creating account inbox:', error);
return;
}
console.log('--- Sent create-account-inbox response');
Copy link

Copilot AI Aug 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This log message indicates a response was sent, but there is no actual response being sent to the WebSocket in this case. The function only broadcasts to other clients via broadcastAccountInbox but doesn't send a direct response to the current WebSocket.

Copilot uses AI. Check for mistakes.

break;
}
case 'get-latest-space-inbox-messages': {
console.log('--- Received get-latest-space-inbox-messages message');
try {
// Check that the user has access to this space
await getSpace({ accountAddress, spaceId: data.spaceId, appIdentityAddress });
Expand All @@ -968,12 +986,14 @@ webSocketServer.on('connection', async (webSocket: CustomWebSocket, request: Req
};
webSocket.send(Messages.serialize(outgoingMessage));
} catch (error) {
console.error('Error getting latest space inbox messages:', error);
console.error('--- Error getting latest space inbox messages:', error);
return;
}
console.log('--- Sent get-latest-space-inbox-messages response');
break;
}
case 'get-latest-account-inbox-messages': {
console.log('--- Received get-latest-account-inbox-messages message');
try {
// Check that the user has access to this inbox
await getAccountInbox({ accountAddress, inboxId: data.inboxId });
Expand All @@ -989,21 +1009,25 @@ webSocketServer.on('connection', async (webSocket: CustomWebSocket, request: Req
};
webSocket.send(Messages.serialize(outgoingMessage));
} catch (error) {
console.error('Error getting latest account inbox messages:', error);
console.error('--- Error getting latest account inbox messages:', error);
return;
}
console.log('--- Sent get-latest-account-inbox-messages response');
break;
}
case 'get-account-inboxes': {
console.log('--- Received get-account-inboxes message');
const inboxes = await listAccountInboxes({ accountAddress });
const outgoingMessage: Messages.ResponseAccountInboxes = {
type: 'account-inboxes',
inboxes,
};
webSocket.send(Messages.serialize(outgoingMessage));
console.log('--- Sent get-account-inboxes response');
break;
}
case 'create-update': {
console.log('--- Received create-update message');
try {
// Check that the update was signed by a valid identity
// belonging to this accountAddress
Expand Down Expand Up @@ -1048,8 +1072,9 @@ webSocketServer.on('connection', async (webSocket: CustomWebSocket, request: Req
currentClient: webSocket,
});
} catch (err) {
console.error('Error creating update:', err);
console.error('--- Error creating update:', err);
}
console.log('--- Sent create-update response');
Copy link

Copilot AI Aug 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This log message indicates a response was sent, but there is no actual response being sent to the WebSocket in this case. The function only broadcasts updates to other clients via broadcastUpdates but doesn't send a direct response to the current WebSocket.

Suggested change
console.log('--- Sent create-update response');
// Send error response to client
const errorMessage: Messages.ResponseError = {
type: 'error',
error: err instanceof Error ? err.message : String(err),
requestType: 'create-update',
};
webSocket.send(Messages.serialize(errorMessage));
responseSent = true;
}
if (responseSent) {
console.log('--- Sent create-update response');
}

Copilot uses AI. Check for mistakes.

break;
}
default:
Expand All @@ -1058,7 +1083,7 @@ webSocketServer.on('connection', async (webSocket: CustomWebSocket, request: Req
}
}
} catch (error) {
console.error('Error processing message:', error);
console.error('--- Error processing message:', error);
}
});
webSocket.on('close', () => {
Expand Down
Loading