add updates sync #49
Merged
add updates sync #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmwhited
approved these changes
Nov 22, 2024
| spaceId, | ||
| }; | ||
| if (client.readyState === WebSocket.OPEN && client.subscribedSpaces.has(spaceId)) { | ||
| client.send(JSON.stringify(outgoingMessage)); |
There was a problem hiding this comment.
Just curious, have we considered using protobuf here? May not be worth it, but curious on your thoughts
There was a problem hiding this comment.
yeah, makes a lot of sense here
the main reason why I didn't so far: I yet haven't worked with it and didn't know which library to use or if there are best practices to consider. I created an issue and we can flesh out the details there #53
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation video here: https://geo-browser.slack.com/archives/C07V73HULPJ/p1732295795968029