Skip to content

Conversation

nikgraf
Copy link
Collaborator

@nikgraf nikgraf commented Aug 19, 2025

closes #507

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses TypeScript compilation issues by updating TypeScript configurations, fixing import paths, and correcting type definitions. The changes ensure the project builds correctly with proper type checking across all packages and applications.

Key changes include:

  • Standardized TypeScript configuration with proper output directories and build settings
  • Updated package paths and imports to resolve module resolution issues
  • Fixed type definitions and import statements throughout the codebase

Reviewed Changes

Copilot reviewed 27 out of 29 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tsconfig.base.json Removed empty line for cleaner formatting
packages//tsconfig..json Added outDir and noEmit configurations for proper build output
package.json Updated TypeScript check command to use project references
apps/template-*/tsconfig.json Added workspace package path mappings
apps/server/* Fixed Prisma import paths and type definitions
apps/events/* Corrected route parameter naming and import statements
apps/connect/src/routes/authenticate.tsx Removed unused variable assignment
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@nikgraf nikgraf merged commit a00e0f4 into main Aug 20, 2025
6 checks passed
@nikgraf nikgraf deleted the ng/fix-ts-check branch August 20, 2025 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant