-
Notifications
You must be signed in to change notification settings - Fork 8
feat: identity and authentication #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
91d0074
to
f5057ae
Compare
1f06818
to
6568b06
Compare
nikgraf
reviewed
Dec 23, 2024
nikgraf
reviewed
Dec 23, 2024
nikgraf
reviewed
Dec 23, 2024
nikgraf
reviewed
Dec 23, 2024
nikgraf
reviewed
Dec 23, 2024
7c2807b
to
2110a03
Compare
This PR adds a basic authentication mechanism using random session tokens and using Sign-in with Ethereum for users to authenticate with their wallets (including Privy embedded wallets). It also adds an identity mechanism by generating encryption and signing keys for each user, which are stored on the sync server using a secret based on a wallet signature, similarly to XMTP v2.
2110a03
to
1ce47a1
Compare
nikgraf
reviewed
Jan 8, 2025
nikgraf
reviewed
Jan 8, 2025
nikgraf
reviewed
Jan 8, 2025
nikgraf
reviewed
Jan 8, 2025
nikgraf
reviewed
Jan 8, 2025
f41bc9e
to
3278a59
Compare
nikgraf
reviewed
Jan 8, 2025
nikgraf
reviewed
Jan 8, 2025
nikgraf
reviewed
Jan 8, 2025
nikgraf
reviewed
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm through with the review! Outstanding work @pcarranzav 👏
nikgraf
approved these changes
Jan 8, 2025
This was referenced Jan 8, 2025
jfyi I added two more issue we need to look into at some point: |
Thanks for capturing all these issues @nikgraf! I'll address them as soon as I'm back from vacation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a basic authentication mechanism using random session tokens and using Sign-in with Ethereum for users to authenticate with their wallets (including Privy embedded wallets).
It also adds an identity mechanism by generating encryption and signing keys for each user, which are stored on the sync server using a secret based on a wallet signature, similarly to XMTP v2.
This is only an initial implementation to be iterated on. Some future improvements or things left for future PRs are (and there's probably others):