Skip to content

Conversation

nikgraf
Copy link
Collaborator

@nikgraf nikgraf commented Dec 28, 2024

I integrated the schema work into the framework. By doing so I removed the relation implementation since it don't match the desired spec/behaviour as defined in this PR: #71
In addition I aligned the API of createEntity and updateEntity with agreed proposal.

Demo:

schema-integration.mov

@nikgraf nikgraf self-assigned this Dec 28, 2024
Copy link
Collaborator

@cmwhited cmwhited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clean. Good work

@nikgraf
Copy link
Collaborator Author

nikgraf commented Jan 6, 2025

thanks @cmwhited 🙌

@nikgraf nikgraf merged commit 8aec2c0 into main Jan 6, 2025
1 check passed
@nikgraf nikgraf deleted the schema-integration branch January 6, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants