Skip to content

add model based nominal type system #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 14, 2025
Merged

add model based nominal type system #88

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
60b858c
add model based nominal type system
fubhy Jan 13, 2025
49b6829
cleanup
nikgraf Jan 13, 2025
7382637
fix tests
nikgraf Jan 13, 2025
df454d7
filter queries by types
nikgraf Jan 13, 2025
f06c94c
use @effect/experimental/VariantSchema
fubhy Jan 13, 2025
644dacf
lint
fubhy Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 9 additions & 15 deletions apps/events/src/components/todos-app.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,16 @@
import { useState } from 'react';
import { useCreateEntity, useDeleteEntity, useQuery, useUpdateEntity } from '../schema';

import { useCreateEntity, useDeleteEntity, useQuery, useUpdateEntity } from '@graph-framework/schema';

import { Todo } from '../schema';
import { Button } from './ui/button';
import { Input } from './ui/input';

export const TodosApp = () => {
const createEntity = useCreateEntity();
const updateEntity = useUpdateEntity();
const todos = useQuery(Todo);
const createEntity = useCreateEntity(Todo);
const updateEntity = useUpdateEntity(Todo);
const deleteEntity = useDeleteEntity();
const todos = useQuery({ types: ['Todo'] });
const [newTodoTitle, setNewTodoTitle] = useState('');

return (
Expand All @@ -17,10 +20,7 @@ export const TodosApp = () => {
<Input type="text" value={newTodoTitle} onChange={(e) => setNewTodoTitle(e.target.value)} />
<Button
onClick={() => {
createEntity({
types: ['Todo'],
data: { name: newTodoTitle, completed: false },
});
createEntity({ name: newTodoTitle, completed: false });
setNewTodoTitle('');
}}
>
Expand All @@ -33,13 +33,7 @@ export const TodosApp = () => {
<input
type="checkbox"
checked={todo.completed}
onChange={(e) =>
updateEntity({
id: todo.id,
types: ['Todo'],
data: { completed: e.target.checked },
})
}
onChange={(e) => updateEntity(todo.id, { completed: e.target.checked })}
/>
<Button onClick={() => deleteEntity(todo.id)}>Delete</Button>
</div>
Expand Down
13 changes: 6 additions & 7 deletions apps/events/src/schema.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
import { createSchemaHooks, type } from '@graphprotocol/graph-framework';
import { Model, Types } from '@graphprotocol/graph-framework';

export const { useCreateEntity, useDeleteEntity, useQuery, useUpdateEntity } = createSchemaHooks({
Todo: {
name: type.Text,
completed: type.Checkbox,
},
});
export class Todo extends Model.Class<Todo>('Todo')({
id: Model.Generated(Types.Text),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this will be moved to be implicit and doesn't have to be defined.

name: Types.Text,
completed: Types.Checkbox,
}) {}
5 changes: 3 additions & 2 deletions packages/graph-framework-schema/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,23 +31,24 @@
"@automerge/automerge": "^2",
"@automerge/automerge-repo": "^2",
"@automerge/automerge-repo-react-hooks": "^2",
"@effect/sql": "^0.25.1",
"effect": "^3.10.19",
"react": "^18"
},
"devDependencies": {
"@automerge/automerge": "^v2.2.9-alpha.3",
"@automerge/automerge-repo": "^2.0.0-alpha.14",
"@automerge/automerge-repo-react-hooks": "^2.0.0-alpha.14",
"effect": "^3.10.19",
"@effect/sql": "^0.25.1",
"@testing-library/jest-dom": "^6.5.0",
"@testing-library/react": "^16.0.1",
"@types/react": "^18.3.7",
"@types/uuid": "^10.0.0",
"@vitejs/plugin-react": "^4.3.2",
"effect": "^3.10.19",
"jsdom": "^25.0.1"
},
"dependencies": {
"fast-deep-equal": "^3.1.3",
"@graph-framework/utils": "workspace:*"
}
}
Loading
Loading