consolidate packages & rename to hypergraph #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikgraf
force-pushed
the
ng/consolidate-pkg
branch
from
689726c to
9f89641
Compare
nikgraf
force-pushed
the
ng/consolidate-pkg
branch
from
58c50b1 to
60b85e3
Compare
nikgraf
changed the title
cmwhited
approved these changes
Jan 14, 2025
| }); | ||
|
|
||
| expect(decrypted).toEqual(message); | ||
| expect(new Uint8Array(decrypted)).toEqual(new Uint8Array(message)); |
There was a problem hiding this comment.
I ran into the same issue in my branch. I created a Uint8Array comparison checker. But wondering what caused these tests to now fail
|
|
||
| describe('identity encryption', () => { | ||
| it('should encrypt and decrypt an identity using a wallet', async () => { | ||
| it.skip('should encrypt and decrypt an identity using a wallet', async () => { |
There was a problem hiding this comment.
Ran into this issue as well. I tried downgrading the deps to what is in the current pkg to try and fix it, and no luck. Not sure what is happening
| it('should generate and verify ownership proofs', async () => { | ||
| // generate a random private key to simulate a user wallet | ||
| const account = privateKeyToAccount(bytesToHex(randomBytes(32))); | ||
| const account = privateKeyToAccount(bytesToHex(randomBytes(32)) as Hex); |
There was a problem hiding this comment.
I updated bytesToHex to return an instance of Hex would resolve this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My main goal was to consolidate asap so we can avoid creating tons of conflicts in upcoming PRs.
I moved all the packages in one commit. The benefit is that then git detects them as moves file and it's easier to go back in history of a file.
I would restructure a lot of the imports, but we can do this as a follow-up.
TIL: two Uint8Arrays can have the same content, but might have a different buffer length they won't be equal. That's why I wrapped several Uin8Array comparisons in tests again with a new Uint8Array. Then they won't have additional buffer length.
There is still one test that fails and I created a follow up issue: #90