Skip to content

refactor: use graphql_client crate #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 9, 2024
Merged

refactor: use graphql_client crate #179

merged 2 commits into from
Oct 9, 2024

Conversation

@gusinacio
Copy link
Contributor

@gusinacio gusinacio commented May 21, 2024 •
edited
Loading

Fixes #64

@gusinacio gusinacio force-pushed the gusinacio/refactor-graphql-client branch 2 times, most recently from c94c73b to 39da354 Compare August 12, 2024 22:07
@gusinacio gusinacio force-pushed the gusinacio/refactor-graphql-client branch 2 times, most recently from 10edb7f to 0f9334e Compare October 4, 2024 14:49
@gusinacio gusinacio requested a review from carlosvdr October 4, 2024 15:09
@gusinacio gusinacio marked this pull request as ready for review October 4, 2024 15:09
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11256499177

Details

  • 88 of 154 (57.14%) changed or added relevant lines in 6 files are covered.
  • 8 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.1%) to 70.649%
Changes Missing Coverage Covered Lines Changed/Added Lines %
common/src/attestations/dispute_manager.rs 2 3 66.67%
common/src/escrow_accounts.rs 32 33 96.97%
common/src/subgraph_client/client.rs 36 41 87.8%
common/src/allocations/monitor.rs 0 59 0.0%
Files with Coverage Reduction New Missed Lines %
common/src/escrow_accounts.rs 1 91.8%
common/src/allocations/monitor.rs 1 0.0%
common/src/subgraph_client/client.rs 6 78.78%
Totals Coverage Status
Change from base Build 11255620002: 0.1%
Covered Lines: 4465
Relevant Lines: 6320
💛 - Coveralls

@gusinacio gusinacio force-pushed the gusinacio/refactor-graphql-client branch 2 times, most recently from 1999fde to a93dae5 Compare October 4, 2024 16:46
@gusinacio gusinacio marked this pull request as draft October 4, 2024 16:51
@gusinacio gusinacio force-pushed the gusinacio/refactor-graphql-client branch 2 times, most recently from eda19a7 to b7dc2ab Compare October 4, 2024 17:36
@gusinacio gusinacio marked this pull request as ready for review October 4, 2024 17:38
@gusinacio gusinacio force-pushed the gusinacio/refactor-graphql-client branch from b7dc2ab to 9237ee1 Compare October 9, 2024 13:56
@gusinacio gusinacio force-pushed the gusinacio/refactor-graphql-client branch from 9237ee1 to b8adaca Compare October 9, 2024 14:39
carlosvdr
carlosvdr previously approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@carlosvdr carlosvdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gusinacio gusinacio force-pushed the gusinacio/refactor-graphql-client branch from 9782112 to 1114274 Compare October 9, 2024 18:09
@gusinacio gusinacio enabled auto-merge (squash) October 9, 2024 18:15
@gusinacio gusinacio changed the title refactor(all): use graphql_client crate refactor: use graphql_client crate Oct 9, 2024
@gusinacio gusinacio merged commit 7d515df into main Oct 9, 2024
21 checks passed
@gusinacio gusinacio deleted the gusinacio/refactor-graphql-client branch October 9, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@carlosvdr carlosvdr carlosvdr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Look into using graphql_client

2 participants

@gusinacio @carlosvdr