- 
                Notifications
    You must be signed in to change notification settings 
- Fork 24
feat: add metrics to service #319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Gustavo Inacio <[email protected]>
Signed-off-by: Gustavo Inacio <[email protected]>
| Pull Request Test Coverage Report for Build 11107661730Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes. 
 Details
 
 
 
 💛 - Coveralls | 
Signed-off-by: Gustavo Inacio <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Gustavo Inacio <[email protected]>
6e6a010    to
    c59b64f      
    Compare
  
    | metrics::INDEXER_ERROR | ||
| .with_label_values(&[&code.to_string()]) | ||
| .inc(); | ||
| let explanation = code.message(); | ||
| warn!( | ||
| "Encountered error {}: {}. Cause: {:#?}", | ||
| code.to_string(), | ||
| explanation, | ||
| cause | ||
| ); | ||
| Self { | ||
| code, | ||
| explanation: explanation.to_string(), | ||
| cause, | ||
| } | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some indexers would like to have the error information on their metrics. This means bringing back error codes mapping. This could be on a following PR depending on priorities for having this kind of metric.
| We got a thumbs up from indexers who are testing this PR on their production environment. | 
Close #274
Close #4