Skip to content

Conversation

@gusinacio
Copy link
Contributor

@gusinacio gusinacio commented Sep 20, 2024

Close #274
Close #4

Signed-off-by: Gustavo Inacio <[email protected]>
Signed-off-by: Gustavo Inacio <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Sep 20, 2024

Pull Request Test Coverage Report for Build 11107661730

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 13 of 150 (8.67%) changed or added relevant lines in 4 files are covered.
  • 72 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.9%) to 69.136%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/src/indexer_service/http/indexer_service.rs 0 23 0.0%
service/src/routes/cost.rs 0 34 0.0%
common/src/indexer_service/http/request_handler.rs 0 80 0.0%
Files with Coverage Reduction New Missed Lines %
common/src/tap/checks/deny_list_check.rs 1 98.21%
common/src/indexer_service/http/indexer_service.rs 1 0.0%
service/src/routes/cost.rs 1 0.0%
common/src/indexer_service/http/request_handler.rs 32 0.0%
tap-agent/src/agent/sender_allocation.rs 37 90.21%
Totals Coverage Status
Change from base Build 10948463940: 0.9%
Covered Lines: 4218
Relevant Lines: 6101

💛 - Coveralls

carlosvdr
carlosvdr previously approved these changes Sep 20, 2024
Copy link
Contributor

@carlosvdr carlosvdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gusinacio gusinacio force-pushed the gusinacio/service-metrics branch 2 times, most recently from 6e6a010 to c59b64f Compare September 30, 2024 15:00
@gusinacio gusinacio requested a review from carlosvdr September 30, 2024 15:45
Comment on lines -307 to -321
metrics::INDEXER_ERROR
.with_label_values(&[&code.to_string()])
.inc();
let explanation = code.message();
warn!(
"Encountered error {}: {}. Cause: {:#?}",
code.to_string(),
explanation,
cause
);
Self {
code,
explanation: explanation.to_string(),
cause,
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some indexers would like to have the error information on their metrics. This means bringing back error codes mapping. This could be on a following PR depending on priorities for having this kind of metric.

@gusinacio
Copy link
Contributor Author

We got a thumbs up from indexers who are testing this PR on their production environment.

@gusinacio gusinacio requested review from mangas and removed request for aasseman September 30, 2024 19:40
@gusinacio gusinacio merged commit 57c89e2 into main Oct 1, 2024
19 checks passed
@gusinacio gusinacio deleted the gusinacio/service-metrics branch October 1, 2024 16:11
@github-actions github-actions bot mentioned this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feat.Req] Missing metrics from indexer-service Feat: Record metrics

3 participants