Skip to content

fix: Pass receipt error into db #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 20, 2024
Merged

fix: Pass receipt error into db #322

merged 1 commit into from
Sep 20, 2024

Conversation

@carlosvdr
Copy link
Contributor

fixes #272

@carlosvdr carlosvdr self-assigned this Sep 20, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10964194622

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.07%) to 68.353%
Files with Coverage Reduction New Missed Lines %
common/src/tap/checks/deny_list_check.rs 1 98.21%
Totals Coverage Status
Change from base Build 10948463940: 0.07%
Covered Lines: 4216
Relevant Lines: 6168
💛 - Coveralls

gusinacio
gusinacio approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@gusinacio gusinacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gusinacio gusinacio merged commit 212e06a into main Sep 20, 2024
10 checks passed
@gusinacio gusinacio deleted the save-receipt-error branch September 20, 2024 18:32
@github-actions github-actions bot mentioned this pull request Oct 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gusinacio gusinacio gusinacio approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@carlosvdr carlosvdr

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Display more information of failed receipts

4 participants

@carlosvdr @coveralls @gusinacio