Skip to content

fix: Add more information if rav request is timing out #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 20, 2024
Merged

fix: Add more information if rav request is timing out #325

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a47504
fix: Add more information if rav request is timing out
carlosvdr Sep 20, 2024
2e3b93c
fix: add more context as to what to do if user encounter timeout issu…
carlosvdr Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion tap-agent/src/agent/sender_allocation.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -554,7 +554,16 @@ impl SenderAllocationState {
previous_rav
),
)
.await?;
.await
.inspect_err(|err| {
if let jsonrpsee::core::ClientError::RequestTimeout = &err {
warn!(
"Rav request is timing out, maybe request_timeout_secs is too \
low in your config file, try adding more secs to the value. \
If the problem persists after doing so please open an issue"
);
}
})?;

let rav_response_time = rav_response_time_start.elapsed();
RAV_RESPONSE_TIME
Expand Down
Loading