Skip to content

Conversation

@taslimmuhammed
Copy link
Contributor

@taslimmuhammed taslimmuhammed commented Sep 27, 2024

Fixes #273
After running the commands and successful compilation:-
cargo clippy --all-targets --all-features
cargo fmt
cargo sqlx prepare --workspace -- --all-targets

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11075670182

Details

  • 25 of 27 (92.59%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 68.309%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tap-agent/src/agent/sender_allocation.rs 25 27 92.59%
Totals Coverage Status
Change from base Build 10967317486: 0.05%
Covered Lines: 4229
Relevant Lines: 6191

💛 - Coveralls

Copy link
Contributor

@gusinacio gusinacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Invalid receipts have an extra field where we are able to store the reason why the receipt failed.

This new implementation is missing it. Let me know if you need help to add them.

allocation_id,
timestamp_ns,
nonce,
value
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's missing here error_log

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you meant this line
debug!(
"Receipt for allocation {} and signer {} failed reason: {}",
allocation_id.encode_hex(),
receipt_signer.encode_hex(),
receipt_error
);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to store the error logs for all receipts as well.

Take a look at the older version, we were inserting error_log in the old sql.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feat.Req] Bulk insert of failed receipts

3 participants