Skip to content

Conversation

@carlosvdr
Copy link
Contributor

fixes #316

@carlosvdr carlosvdr requested a review from gusinacio October 2, 2024 21:47
@carlosvdr carlosvdr self-assigned this Oct 2, 2024
@coveralls
Copy link

coveralls commented Oct 2, 2024

Pull Request Test Coverage Report for Build 11182283631

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 82 of 88 (93.18%) changed or added relevant lines in 3 files are covered.
  • 20 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.4%) to 70.187%

Changes Missing Coverage Covered Lines Changed/Added Lines %
service/src/config.rs 0 1 0.0%
tap-agent/src/config.rs 0 1 0.0%
config/src/config.rs 82 86 95.35%
Files with Coverage Reduction New Missed Lines %
config/src/config.rs 20 87.88%
Totals Coverage Status
Change from base Build 11133358093: 0.4%
Covered Lines: 4473
Relevant Lines: 6373

💛 - Coveralls

Copy link
Contributor

@gusinacio gusinacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please contact me via Slack

@carlosvdr
Copy link
Contributor Author

Will fix commit from fix - > to feat but dont want to force push until you have finished reviewing

@carlosvdr carlosvdr requested a review from gusinacio October 3, 2024 20:56
Copy link
Contributor

@gusinacio gusinacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I loved this solution. Really elegant and uses the Rusty way. Thank you for this great code.

Here are some small nit-picks, typos and errors that I found on the documentation.

@carlosvdr carlosvdr requested a review from gusinacio October 3, 2024 23:09
@carlosvdr carlosvdr requested a review from gusinacio October 4, 2024 15:02
Copy link
Contributor

@gusinacio gusinacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gusinacio gusinacio merged commit 2b9adcf into main Oct 4, 2024
10 checks passed
@gusinacio gusinacio deleted the db-config-fix branch October 4, 2024 15:12
@github-actions github-actions bot mentioned this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Database configuration alternative

3 participants