Skip to content

fix: add warn where trigger_value is below 0.1 grt #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 4, 2024
Merged

fix: add warn where trigger_value is below 0.1 grt #340

merged 2 commits into from
Oct 4, 2024

Conversation

@carlosvdr
Copy link
Contributor

fixes #323

@carlosvdr carlosvdr self-assigned this Oct 2, 2024
@carlosvdr carlosvdr requested a review from gusinacio October 2, 2024 21:48
@carlosvdr carlosvdr marked this pull request as ready for review October 2, 2024 21:48
@coveralls
Copy link

coveralls commented Oct 2, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11171083386

Details

  • 12 of 19 (63.16%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 69.737%
Changes Missing Coverage Covered Lines Changed/Added Lines %
config/src/config.rs 12 19 63.16%
Totals Coverage Status
Change from base Build 11133358093: -0.02%
Covered Lines: 4376
Relevant Lines: 6275
💛 - Coveralls

gusinacio
gusinacio suggested changes Oct 3, 2024
View reviewed changes
@gusinacio
Copy link
Contributor

Also, technically this is a feature. We are not fixing something that is broken, we are adding an alert functionality.

@carlosvdr
Copy link
Contributor Author

Hmm i dont like it being a feature but its closer to that rather than a fix yes

@carlosvdr carlosvdr force-pushed the max-willing-to-use-error branch from 752b259 to bb3ee33 Compare October 3, 2024 23:08
@carlosvdr carlosvdr requested a review from gusinacio October 3, 2024 23:09
gusinacio
gusinacio approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@gusinacio gusinacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gusinacio gusinacio merged commit 203e1ec into main Oct 4, 2024
10 checks passed
@gusinacio gusinacio deleted the max-willing-to-use-error branch October 4, 2024 08:00
@github-actions github-actions bot mentioned this pull request Oct 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gusinacio gusinacio gusinacio approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@carlosvdr carlosvdr

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create warning for too low trigger value

4 participants

@carlosvdr @coveralls @gusinacio