Skip to content

fix: config comment of using both queryurl and deployment_id #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2024
Merged

fix: config comment of using both queryurl and deployment_id #341

merged 1 commit into from
Oct 4, 2024

Conversation

@carlosvdr
Copy link
Contributor

fixes #257

@carlosvdr carlosvdr requested a review from gusinacio October 2, 2024 21:48
@carlosvdr carlosvdr self-assigned this Oct 2, 2024
@coveralls
Copy link

coveralls commented Oct 2, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11169604737

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 69.757%
Totals Coverage Status
Change from base Build 11133358093: 0.0%
Covered Lines: 4364
Relevant Lines: 6256
💛 - Coveralls

gusinacio
gusinacio suggested changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@gusinacio gusinacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a docs update, please reword your commit.

@carlosvdr carlosvdr requested a review from gusinacio October 3, 2024 23:08
gusinacio
gusinacio approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@gusinacio gusinacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gusinacio gusinacio merged commit f931744 into main Oct 4, 2024
10 checks passed
@gusinacio gusinacio deleted the fixcomment branch October 4, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gusinacio gusinacio gusinacio approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@carlosvdr carlosvdr

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

config: wrong comment about subgraph config

4 participants

@carlosvdr @coveralls @gusinacio